Add support for '/queue type' path #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 32 32
Lines 4051 4051
Branches 873 873
=======================================
Hits 3362 3362
Misses 506 506
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
felixfontein
approved these changes
Apr 17, 2024
|
@samburney thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for partially implemented '/queue type' path.
RouterOS includes a number of default queue types that cannot be modified or removed, meaning that to use 'handle_absent_entries' additional work must be done to ensure those are included in the api_modify data.
I know dynamic and default entries are supposed to be ignored by api_info and api_modify, but I haven't worked out how to make that work on this path.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
RouterOS 6.x supports the following queue types:
In addition to these, RouterOS 7.x supports the following:
I have tested each type in both RouterOS versions to ensure basic configurations work, but I won't include that output here as its quite a lot of text.